Closed mtedeschi closed 6 years ago
@mtedeschi we're planning to give this more thought, right? The comment wasn't updated
@jmaj: the marker (and annotation box) is absolutely positioned, right? To the contain that its in (the annotation area). What if we position the annotation box absolutely left: 0; right: 0; just to make it fill the space. I feel like there has to be a way we can make this work that doesn't require a rewrite.
I've tried left, right: 0 with margin: 0 auto before
It does what it should do but it's also somewhat buggy. If they alter the pin's location while opening and closing the popup. It moves the pin which leads to a never having the pin on the word you want unless you do it just right.
Is the plan to come up with a solution instead of just letting them print the document?
@jmaj: can we implement this with the bugginess and try it out to see if its a viable solution, or if its simply to frustrating to get right?
@mtedeschi it's up. Check it out when you can. It's mobile only so it wouldn't come up on iPad Portrait
I think this is good. Two small things:
Reduced the container area by 50% and removed the margin on mobile on the annotation screen
See #515 for the full thread. The issue is resolved except for mobile.