InteractiveMechanics / nmai-nk360-interactives

0 stars 0 forks source link

[x] Pins are slightly off the selected text #641

Closed amberreeves closed 6 years ago

amberreeves commented 6 years ago

As the tool currently functions, the area that the user drags a themed pin to is slightly off the text or image field that the user selects. If you look at the screen grab below, you’ll see that the pins are tagged to the terms “ranges” and “Crow”, which are terms I wanted to select using the tool. However, as I use the tool, the pin point (see red circle) jumps a bit when placed, which could lead to a user misplacing the pin marker for annotating.

nk360 annotator screens 1

From Mike: Let's see if we can recreate and try to refine a bit further.

jmaj commented 6 years ago

What do they mean by it's slightly off the selected text? The pin will be on whatever word is highlighted.

Or do they want the pin towards the first letter? If so, I can move it closer but I can't guarantee it in all cases because the length of the word caries.

amberreeves commented 6 years ago

i can't recreate the issue. closing now

amberreeves commented 6 years ago

from NMAI

I just tried it and the issue is that when you grab the pin, the cursor's relationship to the pin is slightly above and to the right. The user places the pin where she wants it, but it's actually the cursor location that the activity is reading. So, the pin snaps to the clicked cursor location (which slightly off).

mtedeschi commented 6 years ago

Update the draggable's offset so it aligns the pin-point on the marker with the tip of the cursor.

jmaj commented 6 years ago

Change the cursor offset.

amberreeves commented 6 years ago

171220 NMAI: On the phone the pins are no longer precise in their placement. You can try, but it is difficult to move them to the exact spot. Once you drop a pin, and try to adjust it slightly, the movement is limited to being able to only able to move up and down.

Hard to drag and drop pins, continue to refine on mobile

mtedeschi commented 6 years ago

I've adjusted this so the pin offset matches your fingers. Still more work to do on it connected to #695.