[x] Theme pins display inconsistently

[amberreeves]

How are the pin colors/shapes determined?

[jmaj]

The order is defined in the annotator.js file. Here's the order from first to last.

[amberreeves]

can you describe how they are displayed? like when i go to a resource, and i'm on the annotation page, and i see the black square and the gray diamond, or whatever, how is the tool selecting those shapes?

[jmaj]

They're images which are order by filename marker-01.png, marker-02.png...marker-05.png in the JavaScript file.

The way they get displayed is based on the number of themes that resource has. So for Right and Responsibilities it will display marker-01.png and marker-02.png.

No shapes are being selected it's just the design of the pin/marker.

[tespenshade]

Each theme should be represented by the same, consistent theme marker. For example: the theme "Rights" is represented by a blue marker (or whatever color, not sure what marker is tied to what theme specifically). The theme "Responsibilities" is represented by a different colored marker, etc.

@amberreeves did that answer your question? I was not part of the convo around how a certain marker is tied to a certain theme, just that the same marker should always represent the same theme to make it consistent for users.

Specific colors and shapes were just my design, I made a set of 5 unique markers when we originally thought there would never be more than 5 themes.

[amberreeves]

the first theme in every annotator is going to be the black square. the second theme of every annotator is going to be the green circle. the third theme of every annotator is going to be the red hexagon. and so on.

[amberreeves]

from the client

In some instances the pin shapes and color do not follow this rule. This one works that way:

http://nmai.si.edu/nk360/pnw-history-culture-regions/pnw1-markup1/

This one does not:

http://nmai.si.edu/nk360/pnw-history-culture-regions/pnw1-markup2/

Here, pins display different and random color and shape combinations each time you select the same resource.

[mtedeschi]

For Laurie: pnw1-markup2 is not generated by our team, so if you're not seeing that behavior it means you are not using the latest code from the repository. This underscores the importance of your team using GitHub so you're getting the latest code changes. We would recommend pulling down the latest code base once additional warranty issues are resolved to ensure you have the latest.

[jmaj]

Ours http://nmai.si.edu/nk360/pnw-history-culture-regions/pnw1-markup1/js/annotator.js

Theirs http://nmai.si.edu/nk360/pnw-history-culture-regions/pnw1-markup2/js/annotator.js

As mike said the JS isn't up to date. And actually this was completed in issue #509 so it seems they are a bit behind on updating.

[amberreeves]

sent to the client