[4-6] Pins disappear, display out of order

[amberreeves]

On iphone, when you drag and drop a pin, the pin disappears. then, when you drag and drop another pin (a different theme/icon) the icon that is dropped is not the one selected. The first pin doesn’t display when dropped. When the second pin is dropped, it displays the first pin icon. When the third is dropped, it displays the second pin icon, and so on.

@mtedeschi i tested this on my iphone. the link i have is for the Values annotator, so there is only the one theme/pin/icon. so i can confirm that when i drop the values pin, it does not display over the text (it just disappears). however, since there aren't additional themes for this instance, i cannot confirm that dropping a second theme pin would show the first theme pin icon.

[mtedeschi]

This could be a big time suck for me. I'm going to prioritize everything else and come back to this at the end.

[mtedeschi]

Okay. Here's where I ended up: I redid the mobile markers and got them to be fixed position on screen. I added a close button to make it easier to close the annotation popup.

I'd like to test this a bit in the morning before deploying to make sure its working properly across screen sizes and as we expect.

[amberreeves]

sounds good. let me know when i can update laurie.

[mtedeschi]

I've done a good amount of retooling on this to get it working better, particularly on mobile. Right now, I have a few known issues:

• ~On mobile, the pin (when places on a text item, first) will move to the right side when you start dragging it. Kind of connected to #641.~
• ~On all devices, the position of the pin placed on the photo isn't quite align to where it should be (depending on where the text box should go).~

[mtedeschi]

Continued progress. State of current issues:

• ~On mobile, the pin is offset when dragging/placing over the image, specifically.~
• ~On mobile, the pin is not displayed when dragging from a word. This is actually connected to the last issue, below.~
• ~On desktop, the pin is now accurately placed and grabbed when dragging only when you close to annotation box FIRST. If you leave the box open, the dragging when flipped for the right half of the screen gets offset incorrectly (resolution is to force close the box on drag, always).~

[mtedeschi]

New updates:

• ~On mobile, the pin is no longer displaying off-screen. It is still offset slightly across text and images, usually when the pin is closed (it'll jump after that).~

[mtedeschi]

We're very close on this now. There are two outstanding bugs that I'd like to try to resolve for the next delivery, which hopefully shouldn't take too much more time:

• ~On mobile, the pin is offset slightly when you open/close the annotation box.~
• ~On desktop/mobile, if you drag the pin when it is open, it has some buggy behavior between which side it gets opened on (left or right).~

[mtedeschi]

Finished. Seems to be working seamlessly across small and large screens. Solved all known issues above. Someone buy me a beer.