search

InteractiveMechanics / nmai-nk360-interactives

0 stars 0 forks source link

[0.5-1] When theme runs to a 2nd line the # of Pins Remaining is no longer visible #697

Closed amberreeves closed 6 years ago

amberreeves commented 6 years ago

When the theme runs to a 2nd line the # of Pins Remaining is no longer visible. Instead it shows "NaN remaining" under the pin icon on the left.

@mtedeschi i have no other information for this one. let me know if you can't find it/recreate it and i can ask for more details.

mtedeschi commented 6 years ago

I may need help figuring out where this is happening, the issue isn't very specific. I'll try to address first and let you know if I need more info.

mtedeschi commented 6 years ago

@amberreeves: this is because they're entering themes that are more than one word, which we had discussed/advised against. I can only recreate this if the theme is multiword.

If we want to push back on them, then this issue is resolved. If not, then I'll have to rewrite a bunch of code to fix it and likely can't do that today.

amberreeves commented 6 years ago

right. i reminded laurie of the character count we recommend for the themes. i told her they can either reduce the number of characters here or we could explore rewriting the code for this functionality post-launch. closing this for now.