Interactml / iml-unreal

55 stars 18 forks source link

RapidLib thread issues #1

Open mzed opened 3 years ago

mzed commented 3 years ago

Currently, RapidLib train() and run() methods aren't threadsafe. Some proposed fixes:

mzed commented 3 years ago

@samswain All these run methods are running on a reference to some input data object that is outside of the model. So, if that object changes then the results are going to be off. That should probably be passed by value, instead.

sam-apparance commented 2 years ago

The plugin can run these in the background, but makes sure it's only possible to run one at a time for now.

mzed commented 2 years ago

Can you pass data by value? If not, I can have a look. This week.

mzed commented 2 years ago

I think all of the other changes were made a year ago. Not at my computer

sam-apparance commented 2 years ago

Don't worry, I was just tying up this loose end a little. For now we work around the thread-safety issue.