Interbotix / interbotix_ros_toolboxes

Support-level ROS Packages for Interbotix Robots
BSD 3-Clause "New" or "Revised" License
29 stars 68 forks source link

fix ResourceManager constructor for rolling #78

Closed samyk closed 1 week ago

samyk commented 1 week ago

rolling (and jazzy) hardware_interface::ResourceManager has an updated constructor requiring a clock and logger interface, this update supports this to allow interbotix_xs_ros_control to compile

lukeschmitt-tr commented 1 week ago

Thanks for the fix!

samyk commented 1 week ago

Sure! FYI, I'm setting up Aloha Mobile on Ubuntu 24 (even though support is only for up to 22), and using ROS2 Jazzy (have gotten all packages working except one), but there are no branches for the packages for Jazzy for me to PR to. Is this something you can produce? I started from the rolling branch in most cases for Jazzy for the various Interbotix packages, but perhaps a different branch makes more sense as the base?

lukeschmitt-tr commented 1 week ago

I created jazzy branches on all the relevant interbotixros* repos earlier today — feel free to PR as needed. Thanks again for your contribution and feel free to reach out to let us know how the Mobile works (or doesn't) on Jazzy.