Intercoin / CommunityContract

Smart contract for managing community membership and roles
https://intercoin.org
GNU Affero General Public License v3.0
1 stars 2 forks source link

hooks or CommunityContract #29

Closed artman325 closed 1 year ago

artman325 commented 1 year ago

Limits on roles will be implemented in hooks or CommunityContract 2.0 Just make hookAdd and hookRemove. And accountForOperation will check if there is a hook and do same call as with CostManager pushHook like in NFT And make factory public Make NFT master branch yp to date

artman325 commented 1 year ago

contract already intergrated with hook https://github.com/Intercoin/CommunityContract/blob/main/contracts/interfaces/ICommunityHook.sol and can call external hook methods (if present) Seems need to be able to change hook in contract lifetime.

Keep in mind that such hook is not the same as accountForOperation and CostManager btw

EGreg commented 1 year ago

Okay great then nothing to do if hook is available

On Mon, Dec 5, 2022 at 2:05 PM artman325 @.***> wrote:

contract already intergrated with hook

https://github.com/Intercoin/CommunityContract/blob/main/contracts/interfaces/ICommunityHook.sol and can call external hook methods (if present) Seems need to be able to change hook in contract lifetime.

Keep in mind that such hook is not the same as accountForOperation and CostManager btw

— Reply to this email directly, view it on GitHub https://github.com/Intercoin/CommunityContract/issues/29#issuecomment-1337986869, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACV7P6SQPJ6E3Y7DMWA7B3WLY4INANCNFSM6AAAAAASUT3FSM . You are receiving this because you were assigned.Message ID: @.***>

-- Sincerely, Greg Magarshak Qbix Inc.

(To set up a meeting: https://calendly.com/qbix/meeting)

artman325 commented 1 year ago

if nothing need to do then issue has solved :)