Implement delays (timelocks)

[EGreg]

In params, add uint32 delay which is the number of seconds to delay since executing "this line":https://github.com/Intercoin/ControlContract/blob/a800a4c8f56b321d5e90407a69035981de1b62d5/contracts/ControlContract.sol#L568

Please emit OperationScheduled right before OperationExecuted, if delay = 0.

Otherwise if delay > 0 then push this operation to the operations array, and emit OperationScheduled only.

I didn't find anything in OpenZeppelin to have an array with "from" and "to" indexes. You can make a class struct Array struct ArrayWindowwhich can have uint32 startIndex, uint32 endIndex, andwindow.push()andwindow.unshift(). Arrays are really stored as mapping. Thewindow.push(value)will simply storewindow[++endIndex] = valuewhileunshift()willdelete window[startIndex++]` (notice that startIndex is incremented after being evaluated, for clarity you can break it out into two different statements). Anyway, so Operation Scheduled will push the operation.

Meanwhile, anyone can call executeNextOperation() which will var operationId = operations.unshift() and then execute this operation, and emit OperationExecuted. The delete will even save some gas.

So basically, refactor into _executeOperation() which may be called immediately if delay = 0 otherwise from executeNextOperation().

Since delay is the same for the whole contract, the operations would always be executed in order! But with a delay.

[artman325]

This task is about delays, not about the order of executions with delays.

I suggest adding a new method, invoke, with a parameter uint64 delay (defaulting to 0).

function invoke(
    address contractAddress,
    string memory method,
    string memory params,
    uint64 delay
)

The behavior will remain the same. The invoked operation will execute after exceeding the necessary enforced operations. However, if delay != 0, the operation can execute only after the specified delay.

There are no schedules. We cannot wait for a previous operation that might get stuck.

[upd] it would be method addMethod, not invoke

[artman325]

seems workflow are:

• register method with: contract/methodname/params/minimums/fraction and delay by calling addMethod !AND after that we cannot change minimums/fraction and delay for this methods. So set should be immutable BUT we can call addMethod with the same params to add next pair or roles : invoke/endorse

Would be great if invoke can be called with different /minimums/fraction/delay for the same contract/method/params