InterfaceKit / react-native-js-bottom-sheet

A React Native implementation of Android's bottom sheet
MIT License
30 stars 12 forks source link

Android material designs #3

Closed Noitidart closed 6 years ago

Noitidart commented 6 years ago

Thanks for such a superb module. This was so needed because we have iOS ActionSheet out of the box of react native but not the native BottomSheetDialogFragment element of Android? - https://developer.android.com/reference/android/support/design/widget/BottomSheetDialogFragment.html

Would it possible to add cusotmizations to match material styles of what I found in official guidleines here - https://material.io/guidelines/components/bottom-sheets.html#bottom-sheets-modal-bottom-sheets

Moreno97 commented 6 years ago

Hi @Noitidart ! We were planning to add different customisations options to create for example a grid modal. By now, you can modify the source code to archive this. About the native solution you commented, it would be a great idea for the React Native team to implement it, but for now we have to use other solutions provided by the community.

Noitidart commented 6 years ago

Thank you sir very much for your fast and positive reply! I will continue to be a user of this very much needed module! Should I close this out or leave it open? Thank you so much!

Moreno97 commented 6 years ago

I'm glad that you like the library. It can be closed, we'll take into account the possible options to improve the library. If you have ideas you could make a PR about new features and we will take them into account. Greetings!

Noitidart commented 6 years ago

Thanks again very much! I will share feedback as I use this more. :)