Interhyp / SubmissionAPI

public submission API repository
MIT License
3 stars 1 forks source link

Enum for ApplicantRelationshipType incorrectly defined #25

Closed nikfonseca closed 1 year ago

nikfonseca commented 2 years ago

In Schema ApplicantRelationshipType of OpenAPI descriptor submission-api-data.yaml the enum list is incorrectly listed with comma on MARRIED and REGISTERED_PARTNERSHIP, causing incorrect enum generation in Java class

ApplicantRelationshipType:
      type: object
      required:
        - key
      properties:
        key:
          $ref: '#/components/schemas/ApplicantRelationshipTypeKey'
    ApplicantRelationshipTypeKey:
      type: string
      description: |
        DE: Beziehungsart (nicht abschließende Aufzählung) z.B. (MARRIED=mit Ehepartner/in, REGISTERED_PARTNERSHIP=eingetragenem Lebenspartner/in, PARTNERSHIP=Lebenspartner/in). <br/>
        EN: Open ended enum contains values for relation type, possible values are (MARRIED, REGISTERED_PARTNERSHIP, PARTNERSHIP)
      x-extensible-enum:
        - MARRIED,
        - REGISTERED_PARTNERSHIP,
        - PARTNERSHIP
        - OTHER

image

The values should be listed without comma:

ApplicantRelationshipType:
      type: object
      required:
        - key
      properties:
        key:
          $ref: '#/components/schemas/ApplicantRelationshipTypeKey'
    ApplicantRelationshipTypeKey:
      type: string
      description: |
        DE: Beziehungsart (nicht abschließende Aufzählung) z.B. (MARRIED=mit Ehepartner/in, REGISTERED_PARTNERSHIP=eingetragenem Lebenspartner/in, PARTNERSHIP=Lebenspartner/in). <br/>
        EN: Open ended enum contains values for relation type, possible values are (MARRIED, REGISTERED_PARTNERSHIP, PARTNERSHIP)
      x-extensible-enum:
        - MARRIED
        - REGISTERED_PARTNERSHIP
        - PARTNERSHIP
        - OTHER
mohamed-asfour commented 1 year ago

Thanks nikfonseca for reporting this issue and apologies for the late update. This issue should be fixed by now.