Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.73k stars 331 forks source link

[Modding Support] Soul Bound with custom enemies #2567

Open KABoissonneault opened 9 months ago

KABoissonneault commented 9 months ago

When I made the custom enemies framework, I avoided soul traps / soul bound because it was non-trivial.

We should eventually support it. Here's the current situation:

What code is involved in these issues? For point 2, the issue is ItemData_v1. We'd need to migrate to a new version that applies the same fix as #2535. Not too bad, just a lot of copy-paste. For point 3 and 4, the issue is mostly contained in the SoulBound entity effect. I think it's possible that a mod might be able to fix these two issues through a simple effect override? SoulBound has no "special privilege" in the DFU codebase, and all its mechanics are on virtual methods, so any mod could add custom enemy support.

I think I'd like to see a DFU fix for point 2 and 3, and let Daggerfall Enemy Expansion override SoulBound for the extra effects.