search

Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.7k stars 328 forks source link

Fix booleans returned when setting variants #2581

Closed ajrb closed 7 months ago

ajrb commented 7 months ago

The return values were all inverted erroneously, rather embarrassing. Not seen anyone using these return values yet, so should cause no issues.

KABoissonneault commented 7 months ago

Wouldn't it be safer to just update the comments to "True if this X had no existing variants", and changing the variable name? It's not like either way is more intuitive for this function, I think as long as the docs match the behavior, it should be good

ajrb commented 7 months ago

It was wrong and I fixed it. I don't feel it needs the API changing for safety however if that's the consensus I will change it.

ajrb commented 7 months ago

I've done as requested. Added method documentation for getters. Added new block variant getter for when not iterating locations. (i.e. most mod usage)