Fixed Knightly_Guard faction resolve bug.

Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine

http://www.dfworkshop.net

MIT License

2.7k stars 327 forks source link

Fixed Knightly_Guard faction resolve bug. #2590

Closed John-Leitch closed 3 months ago

John-Leitch commented 6 months ago

This PR (hopefully) fixes the following bug: #2510 (0.14.5: "Generic Knightly Order" used as faction in quest dialogue). The update makes Knightly_Guard resolve to a random knightly order, which should fix the faction resolution issue in Q0C20Y02. Since the knightly orders are already hardcoded in the DaggerfallWorkshop.Game.Guilds.KnightlyOrder.Orders enum, the enum values were used instead of adding another hardcoded set of knightly order ids.

KABoissonneault commented 6 months ago

Awesome. Code looks good, just gonna have to test run a few quests to approve this