Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.7k stars 327 forks source link

Fast Travel deducts gold even if travel is canceled #2591

Open KABoissonneault opened 6 months ago

KABoissonneault commented 6 months ago

If you start Fast Travel on the DaggerfallTravelPopup, gold is immediately deducted. However, the fast travel does not complete immediately, and can be canceled during the live update. If it is canceled, the player stays where they were, but still has their gold deducted.

Note that classic DF does not let you cancel travel, this is a DFU issue.

To Reproduce

Steps to reproduce the behavior:

  1. Open Travel map
  2. Click on any location
  3. Start travel
  4. During the update, press Esc to cancel
  5. Look at gold count

Expected behavior

Canceling travel should not deduct gold, since no travel actually happened.

Suggested fix Should simply be a matter of moving the money deduction part of DaggerfallTravelPopUp.CallFastTravelGoldCheck to the end of Update