Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.7k stars 327 forks source link

Relink children if any new custom factions with parents were added #2620

Closed ajrb closed 5 months ago

ajrb commented 5 months ago

Missed this back in 2018. If new custom factions are added by mods and they specify parent factions, this needs to be processed by the child linking code FactionFile.RelinkChildren() otherwise it does nothing.

Found this when Cliffworms added a named NPC to Betony - this should be used at the provinces ruler but it wasn't. Will confirm once this has been completely tested.

Still doesn't help being able to modify existing faction data to, for example, set the ruler value for Betony. Tried some things for that but breakpoints stopped working and I just can't continue today.

ajrb commented 5 months ago

Tested this now using Cliff's mod and it successfully adds a ruler NPC to Betony. Be nice to get this into 1.0.1 since it's nice and self contained.