Closed Mentill closed 5 months ago
Just a heads up, this might be too large for DFU's review process. This is a lot of changes, especially unprompted from a first-time contributor. Even normal 2-3 files changes take weeks to get reviewed. Plus, you might have some overlaps with the existing https://github.com/Interkarma/daggerfall-unity/pull/2619
Might be worth re-submitting these changes as standalone specific changes, so that any of the fixes has a chance to get through. You should probably also only submit one PR at a time, waiting for the previous to be approved before sending another one.
Just a heads up, this might be too large for DFU's review process. This is a lot of changes, especially unprompted from a first-time contributor. Even normal 2-3 files changes take weeks to get reviewed. Plus, you might have some overlaps with the existing #2619
Might be worth re-submitting these changes as standalone specific changes, so that any of the fixes has a chance to get through. You should probably also only submit one PR at a time, waiting for the previous to be approved before sending another one.
As for #2619, I didn't realize that book text wouldn't overflow off the screen (I could've swore I saw it do so, but maybe that was in classic). That one looks better overall. I'll split this so strings are 1 PR and the quest files are another.
This improves spelling/grammar/typos in 170 quest files, and for ~200 strings in the string files. All proofreading was done by hand.
It also substantially improves the formatting of 84 books, elevating them from illegible to readable. Most of them weren't proofread (but are clearly rife with typos; a project for another day.)
The Internal_Locations.csv file was copied to the Text folder so it can override the misspelled names normally loaded directly from MAPS.BSA. I didn't go through all ~15k entries, rather a representative sample since they're procedurally-generated.
Some changes were made to improve consistency. In particular:
I wasn't sure how to edit the images in INVE00I0.IMG & INVE01I0.IMG, which contain the rendered 'Wagon' buttons for the inventory screen, or if it were allowable to include modified versions in DFU's loose texture folder; otherwise, I would've changed every 'Wagon' reference to 'Cart', including that button. I left the Transport menu's 'Cart' button graphic unmodified for the same reason.
changelog