Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.7k stars 327 forks source link

Daggerfall Proofreading Project, Part 1: String Files (Take Two) #2625

Open Mentill opened 5 months ago

Mentill commented 5 months ago

This contains ~200 corrections to spelling & grammar errors/typos to the string files (excluding internal_locations.csv), all done by hand.

The Internal_Locations.csv file was copied to the Text folder so it can override the misspelled names normally loaded directly from MAPS.BSA. I didn't go through all ~15k entries, but rather a representative sample since they're procedurally-generated.

Some changes were made to improve consistency. In particular:

I wasn't sure how to edit the images in INVE00I0.IMG & INVE01I0.IMG, which contain the rendered 'Wagon' buttons for the inventory screen, or if it were allowable to include modified versions in DFU's loose texture folder. Otherwise, I would've changed every 'Wagon' reference to 'Cart', including that button. I left the Transport menu's 'Cart' button graphic unmodified for the same reason.

It was recommended that I split my project into parts submitted one at a time, so this first part is just the string files. Next will be the quests, of which I corrected typos in ~170 of them; if that's too many, I can split that, too. I had improved the formatting of the books, but it seems another PR did a better job on that; I didn't proofread many of those, though. Hopefully I did this all correctly this time, the file diffs all look good to me...

strings notes.txt

petchema commented 5 months ago

I finished my first read of the patch, and it's obvious you spent a lot of time on those fixes, well done!

Mentill commented 5 months ago

I finished my first read of the patch, and it's obvious you spent a lot of time on those fixes, well done!

Thanks! When I did a second pass through the main quests I found a few typos I'd missed the first time, so I probably only found 95% of the issues. I found a bunch of words that seemed wrong but upon research turned out to be nonstandard or archaic forms. I also left the underworld speech and sesquipedalian loquaciousness alone unless there was an obviously-unintended typo. Many of the 'issues' that remain are borderline cases, aesthetic preference, or unusual phrasing that's just not wrong/problematic enough to justify changing the style.