search

Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.67k stars 326 forks source link

Mod Builder removing book mapping contributions #2636

Closed ajrb closed 3 months ago

ajrb commented 3 months ago

I recently released v2.6 of the Archaeologists Guild mod built using the DFU mod builder tool and up to date source code. This release had the book mapping contribution removed from the dfmod.json file by the latest mod builder. I didn't notice this when I committed because the change was at the bottom of the file but this means that v2.6 had no book and so the code for joining the guild which gives the player that book was failing and no one could join anymore. See this link for the json the mod builder removed from my json file: https://github.com/ajrb/dfunity-mods/commit/3654dd2611a6c861e8fbb4078dbfa95448926662#diff-e91627110ad60d228a2c9c75471e495fe7fc2ea922c2a7b5eca2cab912f6c99cL84-L89

This issue was caused by the work in this PR: https://github.com/Interkarma/daggerfall-unity/pull/2580

More specifically this commit: https://github.com/Interkarma/daggerfall-unity/commit/dabcbe9d000a8e785340617ca5233fdee9ad2096

I reverted that commit on my local DFU code clone and restored the json book contribution section. Re-built v2.6.1 of the mod and the mod builder no longer removes this section and the mod works properly

KABoissonneault commented 3 months ago

Fixed by #2637