Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.67k stars 326 forks source link

Last dfmod support for 1.2 #2655

Open KABoissonneault opened 2 months ago

KABoissonneault commented 2 months ago

I'm making one issue for a list of all modding features that still only support "loose files" and not .dfmod. I'd like to clear them completely for 1.2. Feel free to add features in a reply below.

KABoissonneault commented 1 month ago

I can't pinpoint exactly where yet, but the XMLManager is pretty still loose file minded. Functions like XMLManager.XmlFileExists and the path-based constructor only support loose files, making some systems only work with loose files. We should probably rework all of those to use the package-friendly XMLManager.TryReadXml

We have a mod having issues with crosshair replacement, for example. HUDCrosshair uses DaggerfallUI.GetTextureFromResources, which uses TextureReplacement.TryGetSize, which uses XMLManager.XmlFileExists, which only supports loose files.