Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.65k stars 326 forks source link

Add code to permit the use of grammar processors #2656

Open Daneel53 opened 1 month ago

Daneel53 commented 1 month ago

Hello, I would like to ask officially to the team that is today in charge of DFU code to accept to introduce into DFU some code that will permit mods in other languages than English to use a grammar processor in order to produce better translated text in a grammatical point of view.

I wrote a document that explain everything to be clearer.

If the modification is accepted by the team and implemented in a future release of DFU, the French translation shall be the first to benefit of a grammar processor to ameliorate the French translation, it is already working on my PC. Then other translators may try, if they feel ready, to write a mod with their own grammar processor for their language, the French one being an example for them. Grammar processors for DFU.pdf

You can also contact me via my Discord account for further discussion.

Daneel53 commented 3 weeks ago

Hi, Think that I've finally found all the scripts where I have to add calls to both methods of the grammar processor in order to deal with grammar tokens in all the screens of the game.

For calls to ProcessGrammar():

For calls to SetGenreHero():

I've tested in Unity editor all modification with the current code contained into the Github master branch, everything's working fine.

I'm preparing the package and I will create the PR in Github as soon as I will be ready.