search

Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.74k stars 332 forks source link

Fix more one-way staircases #2671

Closed petchema closed 3 months ago

petchema commented 4 months ago

Forums: https://forums.dfworkshop.net/viewtopic.php?t=3482 (original) https://forums.dfworkshop.net/viewtopic.php?t=6720 (new)

petchema commented 4 months ago

SAVE16.zip SAVE17.zip SAVE18.zip SAVE19.zip SAVE20.zip

petchema commented 4 months ago

Could we filter on some "Interior ID"? Because it gets very repetitive...

SAVE1036.zip SAVE1035.zip SAVE1034.zip SAVE1033.zip SAVE1032.zip SAVE1031.zip SAVE1030.zip SAVE1029.zip SAVE1028.zip SAVE1027.zip SAVE1026.zip SAVE1025.zip SAVE1024.zip SAVE1023.zip SAVE1022.zip SAVE1021.zip SAVE1020.zip SAVE1019.zip SAVE1017.zip SAVE1016.zip SAVE1015.zip SAVE1014.zip SAVE1013.zip SAVE1012.zip SAVE1011.zip SAVE1010.zip SAVE1009.zip

KABoissonneault commented 4 months ago

This change is probably good. I know there's the idea that everyone should just be using UBLaMF, but I know no matter how much we raise awareness, some people are going to want to play without mods, and then we need to fix it at a DFU level.

One question I have is, are these changes guaranteed not to interfere with modded versions of those blocks? I don't see a check in the code, but it's possible those Block Index / Entry Index / Model Id are only used in classic data.

petchema commented 4 months ago

SAVE1057.zip SAVE1056.zip SAVE1055.zip SAVE1054.zip SAVE1053.zip SAVE1052.zip SAVE1050.zip SAVE1048.zip SAVE1047.zip SAVE1046.zip SAVE1045.zip SAVE1044.zip SAVE1043.zip SAVE1042.zip SAVE1041.zip SAVE1040.zip SAVE1039.zip SAVE1038.zip SAVE1037.zip

petchema commented 4 months ago

Interkarma may have decided to include those patches in base game because they're somewhat game breaking (player is trapped inside the building if s.he manages to get upstairs). About compatibility with mods, I have no idea. I'm not adding a new mechanism here, just patching more buildings

KABoissonneault commented 4 months ago

Yeah I get it. It's really more that the project is at a point where I don't want to break people's setups for as long as I can avoid it. Gonna have to investigate, or wait for someone with more expertise to weigh in on the compatibility (@XJDHDR maybe?)

petchema commented 4 months ago

I think I'm done with that specific interior, I looked around, mostly in large desert cities (that kind of building only occurs in large towns) SAVE21.zip SAVE22.zip SAVE23.zip SAVE24.zip

XJDHDR commented 4 months ago

I'm pretty sure the IsBadInteriorModel method is only called when blocks are being built from the BSA and not when the data comes from a mod. It might be a good idea to check though.