search

Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.73k stars 331 forks source link

Location list lines after search on travel map are limited to 29 characters #2684

Open Daneel53 opened 2 months ago

Daneel53 commented 2 months ago

After having entered a search clue on the travel map, the resulting list has lines cut at 29 characters. This is probably an issue only for other languages than English that are more verbose.

DaggerfallUnity_2024-08-11_09-03-34

This comes from the script DaggerfallTravelMapWindow.cs where the listbox is explicitely created with MaxCharacters = 29.

notepad++_2024-08-11_10-51-48

I changed the 29 for 50 with the Unity editor and the list is is now correctly displayed.

Unity_2024-08-10_22-13-49

Please change this value in DFU code.

petchema commented 2 months ago

I assume this is done for compatibility with SDF fonts off: Capture d’écran du 2024-08-11 13-21-14 So it will have to depend on current font mode (or better, if this can be implemented, restrict text drawing to scrollable rectangle, which would work for all fonts, specially variable-spaced ones)

Daneel53 commented 2 months ago

I suppose that 29 characters always were enough for the English names, whatever the font is. So, for English, no matter if the line length is pushed to 50, additional chars shall not be used. With other languages, we just cannot play with SDF font because this font don't have any character with accent, which make it totally not usable as your example above with esoteric characters that replace the é and the â shows clearly. So, in other languages than English, SDF font is not to be taken into account, we cannot use it.

I think that we can just change this value for the moment, it is clearly better than to have end of lines cut whatever the font is. After that, if somebody have the time and willing to implement a more clever solution that will work for any font, it will still be possible.