search

Interkarma / daggerfall-unity

Open source recreation of Daggerfall in the Unity engine
http://www.dfworkshop.net
MIT License
2.74k stars 332 forks source link

Allow guild quests to be dispensed by player level as well as rank #2688

Open ajrb opened 3 months ago

ajrb commented 3 months ago

Guild quests can be dispensed by player level as well as rank if minReq is <10 depending on the guild implementation. Proposed alternative to #2678 .

Enabled for Mages Guild and Knightly Orders.

Will add for Witch Coverns if evidence from classic Daggerfall is provided that contradicts https://en.uesp.net/wiki/Daggerfall:Witch_Covens

Only other thought is whether this change should have a way to disable this for players who prefer how DFU 1.0 currently works. Happy to add a setting or ini file property if you think worthwhile, @KABoissonneault & @petchema ?

petchema commented 3 months ago

That's not so simple to check if witches coven consider rank or level, given that all their quests are reputation-gated (when there's any precondition). Unless you were thinking about adding a rank-gated witches quest to classic Daggerfall to check how it'd behave? That's a bit out of my league. If that helps, a save near the Tamarilyn Witches: SAVE5 - Looking for witches.zip Character never had previous contact with them, so I assume reputation is about neutral.

ajrb commented 3 months ago

Switched witches quest dispensing to player level as proven in classic with that save.

It's possible that reputation also enables offers as UESP states, but I'm not implementing that unless it's actually proven to be the case by someone who cares enough to test it. It would require having a witch covern rep at > 10x player level and asking for quests. I think this is unlikely to happen in game but could be tried in classic by finding a covern, doing 3 covern quests successfully without reaching level 2, then getting offered one of the last 3 quests from https://en.uesp.net/wiki/Daggerfall:Witch_Covens.

If someone does show this is how classic works, then I'll implement a special case for witches coverns which was the only faction quests that remained based on reputation since they were all changed back in December 2018 when it was shown that UESP was wrong (at that time) and all switched to rank/level based dispensing. Otherwise I consider it needless complexity based on an unreliable source.