search

Interlisp / medley

The main repo for the Medley Interlisp project. Wiki, Issues are here. Other repositories include maiko (the VM implementation) and Interlisp.github.io (web site sources)
https://Interlisp.org
MIT License
368 stars 19 forks source link

TEdit crashes when closing window while Character Looks menu open #1057

Open pamoroso opened 1 year ago

pamoroso commented 1 year ago

Describe the bug TEdit crashes when closing the window with the Close menu option while the Character Looks menu is open, and a break window appears reporting the error INVALID-ARGUMENT-LIST. The issue is reproducible.

To Reproduce Steps to reproduce the behavior:

  1. sign into your Interlisp Online account
  2. under Initial Exec, select Interlisp
  3. click Run Medley
  4. right-click the desktop
  5. select TEdit
  6. frame the window
  7. middle-click the window title
  8. select Expanded Menu
  9. select Character Looks
  10. right-click the title bar of TEdit's main window
  11. select Close

Expected behavior TEdit's window closes with no break or error.

Screenshots The break window: TEditCrash1

The full desktop: TEditCrash2

Context (please complete the following information):

Additional context TEdit does't crash if the Character Looks menu is closed before executing the Close command of TEdit's main window.

rmkaplan commented 1 year ago

Thanks, I have Tedit open on the operating table, I’ll look at it.

On Jan 28, 2023, at 10:16 AM, Paolo Amoroso @.***> wrote:

Describe the bug TEdit crashes when closing the window with the Close menu option while the Character Looks menu is open, and a break window appears reporting the error INVALID-ARGUMENT-LIST. The issue is reproducible.

To Reproduce Steps to reproduce the behavior:

sign into your Interlisp Online account under Initial Exec, select Interlisp click Run Medley right-click the desktop select TEdit frame the window middle-click the window title select Expanded Menu select Character Looks right-click the title bar of TEdit's main window select Close Expected behavior TEdit's window closes with no break or error.

Screenshots The break window: https://user-images.githubusercontent.com/10342479/215283851-b629c135-ed69-4744-9463-0c10532be2ce.png The full desktop: https://user-images.githubusercontent.com/10342479/215283849-83a8b901-4fd0-48cf-a4c7-196cce76d9bf.png Context (please complete the following information):

OS: chromeOS Stable OS Version: 109.0.5414.94 Host arch: x86_64 (ASUS Chromebox 3) Maiko version: not sure how to get it IL:MAKESYSDATE: 18-Dec-2022 20:59:08 Additional context TEdit does't crash if the Character Looks menu is closed before executing the Close command of TEdit's main window.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/1057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJMC5HTTE5BMWF7FND3WUVO6TANCNFSM6AAAAAAUJYVMAE. You are receiving this because you are subscribed to this thread.

masinter commented 1 year ago

look at the TEdit and mail files in the test repo in: test/library/TEDIT/hand-aux/ for more test cases

rmkaplan commented 1 year ago

I can replicate this behavior running online, but not in a fresh full makesys I build on my mac, on the current master.

The online makesys is dated 18-Dec-22. Maybe something has improved since then?

On Jan 28, 2023, at 10:16 AM, Paolo Amoroso @.***> wrote:

Describe the bug TEdit crashes when closing the window with the Close menu option while the Character Looks menu is open, and a break window appears reporting the error INVALID-ARGUMENT-LIST. The issue is reproducible.

To Reproduce Steps to reproduce the behavior:

sign into your Interlisp Online account under Initial Exec, select Interlisp click Run Medley right-click the desktop select TEdit frame the window middle-click the window title select Expanded Menu select Character Looks right-click the title bar of TEdit's main window select Close Expected behavior TEdit's window closes with no break or error.

Screenshots The break window: https://user-images.githubusercontent.com/10342479/215283851-b629c135-ed69-4744-9463-0c10532be2ce.png The full desktop: https://user-images.githubusercontent.com/10342479/215283849-83a8b901-4fd0-48cf-a4c7-196cce76d9bf.png Context (please complete the following information):

OS: chromeOS Stable OS Version: 109.0.5414.94 Host arch: x86_64 (ASUS Chromebox 3) Maiko version: not sure how to get it IL:MAKESYSDATE: 18-Dec-2022 20:59:08 Additional context TEdit does't crash if the Character Looks menu is closed before executing the Close command of TEdit's main window.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/1057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJMC5HTTE5BMWF7FND3WUVO6TANCNFSM6AAAAAAUJYVMAE. You are receiving this because you are subscribed to this thread.

pamoroso commented 1 year ago

I still get the crash with the x86_64 .deb file of the medley-230130-9ee705b2 release installed on Crostini Linux, the Linux container of chromeOS.

rmkaplan commented 1 year ago

What is the value of IL:MAKESYSDATE ?

On Jan 31, 2023, at 8:24 AM, Paolo Amoroso @.***> wrote:

I still get the crash with the x86_64 .deb file of the medley-230130-9ee705b2 https://github.com/Interlisp/medley/releases/tag/medley-230130-9ee705b2 release installed on Crostini Linux, the Linux container of chromeOS.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/1057#issuecomment-1410683713, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJOX64VIG4EPDKNVSHDWVE4ETANCNFSM6AAAAAAUJYVMAE. You are receiving this because you commented.

pamoroso commented 1 year ago

The value is 30-Jan-2023 23:32:31.

rmkaplan commented 1 year ago

That's close to the “release” sysout that was just announced, except that the MAKESYSDATE for the one I just downloaded is off by 2 seconds: 30-Jan-2023 23:32:29. How can there be a 2 second difference in MAKESYSDATE?

But still, I can’t make it fail when I run on my Mac (with or without my personal greeting). Can anybody else make it fail, other than in Paolo’s configuration?

On Jan 31, 2023, at 8:30 AM, Paolo Amoroso @.***> wrote:

The value is 30-Jan-2023 23:32:31.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/1057#issuecomment-1410696659, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJPNGJMAE5FGCCSGTSLWVE42DANCNFSM6AAAAAAUJYVMAE. You are receiving this because you commented.

fghalasz commented 1 year ago

Here's the story Paolo's break happens on the new apps.sysout (which is very similar to the online.sysout). It does not happen on full.sysout.

Probably this means that some TEdit patch or advice added by Notecards or ROOMS is causing the problem. I will put in my queue to track this down.

And the two second difference reflects that in the github build workflow, that full.sysosout was built two second before apps.sysout. Given that apps.sysout is built on top of a completed full.sysout, those are some impressively fast machines at github.

rmkaplan commented 1 year ago

Good. Let me know what the patch is, maybe it is something that should be moved back into Tedit.

On Jan 31, 2023, at 10:31 AM, Frank Halasz @.***> wrote:

Here's the story Paolo's break happens on the new apps.sysout (which is very similar to the online.sysout). It does not happen on full.sysout.

Probably this means that some TEdit patch or advice added by Notecards or ROOMS is causing the problem. I will put in my queue to track this down.

And the two second difference reflects that in the github build workflow, that full.sysosout was built two second before apps.sysout. Given that apps.sysout is built on top of a completed full.sysout, those are some impressively fast machines at github.

— Reply to this email directly, view it on GitHub https://github.com/Interlisp/medley/issues/1057#issuecomment-1410876949, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSTUJO4K2SAGLDPR75LVK3WVFK7RANCNFSM6AAAAAAUJYVMAE. You are receiving this because you commented.

pamoroso commented 1 year ago

My bad, I miscopied the sysdate and the correct one is indeed 30-Jan-2023 23:32:29. I confirm the crahs doesn't occur when running full.sysout with the -f option.