Intermodalics / ros_android

Cross compilation scripts for building ROS nodes using the Android NDK.
9 stars 5 forks source link

ROS packages download failing from TAR #104

Closed jubeira closed 5 years ago

jubeira commented 5 years ago

This is the second time I see this happening without changes in our side; in this case with laser_assembler and opencv3.

rosinstall_generator is giving an incorrect output (particularly for the version). The output was correct at some point because the download wasn't failing some days ago, but it's not correct now. For example, laser_assembler:

juan@Sullust:~$ rosinstall_generator laser_assembler --tar
Using ROS_DISTRO: kinetic
Package names: ['laser_assembler']
From path: None
Deps: False
Deps up to: None
Deps depth: None
Deps only: False
Excludes: None
Exclude paths: None
Wet: True
Flat: False
Tar: True
- tar:
    local-name: laser_assembler
    uri: https://github.com/ros-gbp/laser_assembler-release/archive/release/kinetic/laser_assembler/1.7.4-0.tar.gz
    version: laser_assembler-release-release-kinetic-laser_assembler-1.7.4-0

If I download the package at that URI, the folder inside the tar file has a different name than the one specified in the version: laser_assembler-release-release-kinetic-laser_assembler (no trailing version number).

I will send a PR correcting this, but it's kinda awful that the contents of a package at a fixed URI change from time to time. @meyerj any thoughts?