Intermodalics / ros_android

Cross compilation scripts for building ROS nodes using the Android NDK.
9 stars 5 forks source link

Minimal reorganization #107

Closed ivanpauno closed 5 years ago

ivanpauno commented 5 years ago
ivanpauno commented 5 years ago

Codewise looks good; I haven't tested it yet. I have a doubt about this point:

Stop downloading rospkg, it's already installed inside the docker container.

rospkg is also downloaded within the catkin workspace, but I don't see how it's accessible to pluginlib helper at the time the script is called. Am I missing something?

rospkg was downloaded directly inside "files" folder before, and was added as a system library download (not in the catkin_ws) in the last reorganization, and copied to "files" folder from there.

It was used only in "plugin_collect.py", specifying from which folder import. It's not really needed, as is part of the packages downloaded with ros-core (in /usr/lib/python2.7/dist-packages/rospkg)