search

Intermodalics / tango_ros

ROS related software for Tango
Apache License 2.0
67 stars 22 forks source link

Feature/preapre new release #254

Closed PerrineAguiar closed 7 years ago

PerrineAguiar commented 7 years ago

PR preparing the new release of the app.

adamantivm commented 7 years ago

@PerrineAguiar one thing, and sorry I missed this in previous PR's, note that if you change the name of the tango_ros_node module, you will change the name with which the library package and artifact is released, leaving behind the older version with no further updates in the repo. Is that the intended behavior? Did you consider using the same package and artifact name with the new implementation?

PerrineAguiar commented 7 years ago

@adamantivm @jubeira Thanks for your comments. I agree that changing the library name is not ideal but as @jubeira said, the new name reflects better what it is. To have the new functionalities, updating the module name and the class is necessary. Do you think it is a big issue? I am asking you because you are the only one I know using the tango_ros_node. I will update the wiki entry as soon as this is merged.

adamantivm commented 7 years ago

I think it's not a big issue, especially since we're the only ones using it (that we know) so far, so it's a good time to change before it has more uses.

On Wed, Apr 26, 2017 at 10:17 AM, Perrine Aguiar notifications@github.com wrote:

@adamantivm https://github.com/adamantivm @jubeira https://github.com/jubeira Thanks for your comments. I agree that changing the library name is not ideal but as @jubeira https://github.com/jubeira said, the new name reflects better what it is. To have the new functionalities, updating the module name and the class is necessary. Do you think it is a big issue? I am asking you because you are the only one I know using the tango_ros_node. I will update the wiki entry as soon as this is merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Intermodalics/tango_ros/pull/254#issuecomment-297404206, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYbcJYJ6qY5FrMwUOZYf5yqHnK1N72yks5rz0PPgaJpZM4NInzh .

PerrineAguiar commented 7 years ago

@smits ptal