Closed PerrineAguiar closed 7 years ago
@mcopejans Thanks for the review, I addressed your comments.
OK, the implementation is quite conservative because permissions for both adf and dataset are always required even if not needed. This could be addressed as a follow up? LGTM
@mcopejans Both permissions are not required to be allowed, but to be asked, i.e. we wait for the user to answer both permissions pop up before starting the node. I will add some comments in the code so things are clearer.
Asking would also not be required in all cases. Only if specific settings are enabled.
Yes, I'll make a follow up to address this.
This PR fixes two issues found while testing on YS: