Intermodalics / tango_ros

ROS related software for Tango
Apache License 2.0
67 stars 22 forks source link

Fix/permission and getmaps ys #263

Closed PerrineAguiar closed 7 years ago

PerrineAguiar commented 7 years ago

This PR fixes two issues found while testing on YS:

PerrineAguiar commented 7 years ago

@mcopejans Thanks for the review, I addressed your comments.

mcopejans commented 7 years ago

OK, the implementation is quite conservative because permissions for both adf and dataset are always required even if not needed. This could be addressed as a follow up? LGTM

PerrineAguiar commented 7 years ago

@mcopejans Both permissions are not required to be allowed, but to be asked, i.e. we wait for the user to answer both permissions pop up before starting the node. I will add some comments in the code so things are clearer.

mcopejans commented 7 years ago

Asking would also not be required in all cases. Only if specific settings are enabled.

PerrineAguiar commented 7 years ago

Yes, I'll make a follow up to address this.