search

Intermodalics / tango_ros

ROS related software for Tango
Apache License 2.0
67 stars 22 forks source link

Allow to disable depth camera + move parameter node to tango_common #265

Closed mcopejans closed 7 years ago

mcopejans commented 7 years ago

Allows to enable/disable the depth camera using Settings Activity or the ROS parameter server.

The PR also moves the parameter node to the tango_ros_common module since it is written in a generic way and can be reused in other Tango-ROS apps.

mcopejans commented 7 years ago

Perhaps we can do the same for color images? I'm guessing this could also save some battery power.

adamantivm commented 7 years ago

+1

On May 5, 2017 8:21 AM, "Marieke Copejans" notifications@github.com wrote:

Perhaps we can do the same for color images? I'm guessing this could also save some battery power.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Intermodalics/tango_ros/pull/265#issuecomment-299493985, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYbcD8JFehU_c7MtGWy6c3ev2b7s1J9ks5r2z4_gaJpZM4NSBRi .

PerrineAguiar commented 7 years ago

@mcopejans I will make a new issue to do the same for color image.

mcopejans commented 7 years ago

Currently implemented like other settings, but needs fix described here: https://github.com/Intermodalics/tango_ros/issues/268