Intermodalics / tango_ros

ROS related software for Tango
Apache License 2.0
67 stars 22 forks source link

Fix consistency settings Settings Activity vs. TangoRosNode #268

Closed mcopejans closed 7 years ago

mcopejans commented 7 years ago

Current situation: If a setting does not exist on ROS parameter server, it will be initialized on the ROS parameter server using its default value. These settings are synced to the Settings Activity AFTER successful Tango connection.

This can lead to inconsistencies since the default value of a setting can be different from the one that was saved in shared preferences from the previous run of the app.

Suggested solution:

  1. Sync all settings from Settings Activity to ROS parameter server BEFORE Tango connection. Advantage: Default values of settings only need to be known in Settings Activity and are not duplicated in Tango ROS node anymore.
  2. Before quitting the app and when starting the Settings Activity, all parameters from ROS parameter server need to be synced to Settings activity.