The constructor of the TangoServiceClientNode class requires an Activity but immediately casts it to another class TangoServiceClientNode.CallbackListener. This is bad coding practice since it leads developers to build programs that will fail at runtime with cryptic problems, causing long debug times.
This is particularly serious since the documentation explaining how to integrate tango_ros_node in other applications is grossly outdated at the moment.
I suggest making the callback optional and moving it to a separate, explicit setListener call.
The constructor of the TangoServiceClientNode class requires an Activity but immediately casts it to another class
TangoServiceClientNode.CallbackListener. This is bad coding practice since it leads developers to build programs that will fail at runtime with cryptic problems, causing long debug times.This is particularly serious since the documentation explaining how to integrate
tango_ros_nodein other applications is grossly outdated at the moment.I suggest making the callback optional and moving it to a separate, explicit setListener call.