Add support for remmaping arguments

Intermodalics / tango_ros

ROS related software for Tango

Apache License 2.0

67 stars 22 forks source link

Add support for remmaping arguments #324

Closed PerrineAguiar closed 7 years ago

PerrineAguiar commented 7 years ago

Fixes #288.

PerrineAguiar commented 7 years ago

@jubeira @adamantivm FYI I tested it but it seems that there is an error on the rosjava side, I opened a PR in the rosjava_core repo to fix this: https://github.com/rosjava/rosjava_core/pull/248.

adamantivm commented 7 years ago

Thank you @PerrineAguiar ! Please let me know when releasing a new public version of rosjava core becomes blocking for this or a new TRS release.

PerrineAguiar commented 7 years ago

@mcopejans Thanks for your review. I addressed your comments and change the code to follow the ROS remapping syntax.

mcopejans commented 7 years ago

LGTM

PerrineAguiar commented 7 years ago

This PR was waiting for this fix on the rosjava side. A new version of rosjava_core which includes the fix has been released. After testing that the remapping feature works as expected, I am merging this PR.