search

InternLandMark / LandMark

Other
452 stars 38 forks source link

Possible errors in colmap2nerf.py #13

Open dhgras opened 1 year ago

dhgras commented 1 year ago

https://github.com/InternLandMark/LandMark/blob/8e65f93f00e0c0e040806ad95ff8f19fb8d42011/app/tools/colmap2nerf.py#L83 I would like to confirm if this line of code is wrong? Because if out_test = out, then out_test is a reference to out, and the final generated transforms_train.json and transforms_test.json are identical.

FlushingCat commented 1 year ago

Hi! After reviewing the code, im quite sure that is a bug 😵. I will fix it in the recent update. Thanks for your help! Replacing the line with out_test = parse_colmap_camera_params(cam_id_to_camera[1]) will restore the expected logic.