search

InternalDeveloperPlatform / public-site

Other
221 stars 106 forks source link

Update configure8.md #144

Closed jjmutron closed 1 year ago

jjmutron commented 1 year ago

Hi Florian - this pr addresses your comments in 143. Matthew is on vacation, so I've submitted this update for him.v Thanks

On Wed, Nov 8, 2023 at 3:30 AM Florian Lipp @.***> wrote:

@.**** commented on this pull request.

Hi @jjmutron https://github.com/jjmutron , thanks for contributing. There is already an open PR, see my comment there: #143 https://github.com/InternalDeveloperPlatform/public-site/pull/143

— Reply to this email directly, view it on GitHub https://github.com/InternalDeveloperPlatform/public-site/pull/144#pullrequestreview-1719665747, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKCB2EC3AXTJOIHSXZBQWLYDM7ITAVCNFSM6AAAAAA6746FHSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJZGY3DKNZUG4 . You are receiving this because you were mentioned.Message ID: @.*** com>

FL303 commented 1 year ago

@jjmutron thanks for letting me know, approved!

jjmutron commented 1 year ago

Thank you!!

On Wed, Nov 8, 2023 at 7:39 AM Florian Lipp @.***> wrote:

@jjmutron https://github.com/jjmutron thanks for letting me know, approved!

— Reply to this email directly, view it on GitHub https://github.com/InternalDeveloperPlatform/public-site/pull/144#issuecomment-1801809843, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKCB2EJJCIAMZ7QJDVPQJLYDN4PXAVCNFSM6AAAAAA6746FHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRHAYDSOBUGM . You are receiving this because you were mentioned.Message ID: @.***>