Closed Sonia-IDSA closed 2 years ago
hey @Sonia-IDSA and @pedro-pinto what is the status with this section and its review? It would be great if we could get the review finished and the pull request merged during the next days...
Hey @Sonia-IDSA could you maybe finish integrating the feedback so that we can get this chapter finalized? Thanks!
Hey @nadjamenz @ssteinbuss and @andreas-teuscher Sonia and I have finished the revision and review of this chapter but for merging the Pull Request we require a second approval. Could one of you maybe take a short look to the chapter and approve it? Thanks!
@mohuber @Sonia-IDSA The changes look good, but there is still an open todo ([TODO: Add chapter on approval of evaluation facilities]). Will this be worked on after finalizing the current Pull Request?
@nadjamenz thanks for the review! The first process (Approval of evaluation facilities) has already been covered in another pull request: https://github.com/International-Data-Spaces-Association/IDS-RAM_4_0/pull/141. Github should be able to automatically merge these together leaving no open points in the chapter.
This changes are also fine for me.
Thanks to both of you @nadjamenz and @andreas-teuscher for the second review!
@Sonia-IDSA thanks a lot for preparing this chapter! I have reviewed it and provided some feedback and proposal for changes :)