International-Data-Spaces-Association / IDS-testbed

Apache License 2.0
24 stars 32 forks source link

Updating the MVDS Visual #110

Closed anilturkmayali closed 1 year ago

anilturkmayali commented 1 year ago

Changed the MVDS visual, by replacing one connector's role as Data Consumer.

The issue was originally raised here: https://github.com/International-Data-Spaces-Association/idsa/issues/129

jfernandezsqs commented 1 year ago

This picture is wrong. It should be Connector B (acting as Data Consumer) and Connector A (acting as Data Provider)

Also, line 33 of the README.md file should be changed accordingly. Wrong --> ![first_version](./pictures/Testbed_1.0.png) Correct --> ![first_version](./pictures/MVDS-Testbed_1.0.png)

robertgroh commented 1 year ago

@jfernandezsqs If I get you right, it should be like this:

graph TD
    A["Connector A (acting as Data Provider)"] -- request data from connector A on request --- C[ ]
    B["Connector B (acting as Data Consumer)"] --  provide data to connector B on request --- C;

    classDef connector fill:#d5e8d4,stroke:#A2C68D,stroke-width:2px
    class A connector;
    class B connector;

   classDef emptybox fill:#ffe6cc,stroke:#D79B01,stroke-width:2px,height:40px,width:160px,x:-80px,y:-20px
   class C emptybox;

I am wondering, if the edge/connection description make any sense in this configuration? What do you think regarding these descriptions?

A: request data from connector A on request B: provide data to connector B on request

anilturkmayali commented 1 year ago

This picture is wrong. It should be Connector B (acting as Data Consumer) and Connector A (acting as Data Provider)

Also, line 33 of the README.md file should be changed accordingly. Wrong --> ![first_version](./pictures/Testbed_1.0.png) Correct --> ![first_version](./pictures/MVDS-Testbed_1.0.png)

Thank you for the feedback @jfernandezsqs the changes are reflected in the updated branch.