search

International-Data-Spaces-Association / IDS-testbed

Apache License 2.0
24 stars 32 forks source link

Update mvds visual #127

Open anilturkmayali opened 1 year ago

anilturkmayali commented 1 year ago

MVDS Visual has been updated with a newer and more modern version of it.

anilturkmayali commented 1 year ago

The figure is not correct:

  1. typo in Identity provider
  2. DAPS has 2 arrows to Connector A but only one to Connector B
  3. The CA issues the certificate to connector A, the arrow is not labeled
  4. Label of DAPS: manages ... participants, here more or less connectors in this figure?

Changes have been applied in the newer version of the visual. Could you please review again? @ssteinbuss @Sonia-IDSA

Thank you, Best wishes, Anil

jfernandezsqs commented 1 year ago

I have reviewed the PR. In the mvds-visual.png file it appears two outgoing arrows from DAPS to ConnectorA. It should be one incoming and one outgoing, as it is for DAPS-ConnectorB interaction arrows. There is a label “Issues certificate” for DAPS-ConnectorA and DAPS-ConnectorB, is this label correctly assigned there?