Closed parwinderau closed 2 months ago
I have reviewed the changes made in this pull request and the modifications made to the docker-compose.yml
and .env
files are correct and I have verified that they do not affect the functionality or interoperability of the environment.
As for the postman collection TestbedPreconfiguration.postman_collection.json
I have detected an error in lines 645 and 661. This failure is due to the {{BROKER_REV_PROXY}}
variable which is not defined and enabled in the active environment (UNRESOLVED variable).
Is the error due to this missing variable at the collection?
@parwinderau Could you please fix the error in the collection?
Thanks in advance ;)
I have fixed the undefined BROKER_REV_PROXY variable.
I have reviewed the changes made in this pull request and the modifications made to the
docker-compose.yml
and.env
files are correct and I have verified that they do not affect the functionality or interoperability of the environment.As for the postman collection
TestbedPreconfiguration.postman_collection.json
I have detected an error in lines 645 and 661. This failure is due to the{{BROKER_REV_PROXY}}
variable which is not defined and enabled in the active environment (UNRESOLVED variable). Is the error due to this missing variable at the collection? @parwinderau Could you please fix the error in the collection?Thanks in advance ;)
Done now. Please check it. BR Parwinder
I have checked the changes and from my side they are fine. I am going to make some minor changes to the documentation to reflect the changes made.
Changes look good to me. Therefore, I approve this pull request.
Thanks. For merging I think there is a need for a second reviewer also. Can you ask someone or assign someone for a second review as well.
There are three fixes identified: