clange
commented
3 years ago @HaydarAk I have checked your two commits
- https://github.com/International-Data-Spaces-Association/InformationModel/pull/367/commits/beea57243ab135300ce2f4ae4d820d36eb86862e
- https://github.com/International-Data-Spaces-Association/InformationModel/pull/367/commits/03522b792ad726bfefcf46a9e6a64fa5d2954dfd and they are fine, thank you!
With @JohannesLipp I agreed to assign this approval back to you, so that you can approve my remaining changes, which I made after your commits.
From the discussion with the colleagues working on the configuration model, following changes were requested:
New class ids:GenericEndpoint, as subclass of ids:Endpoint for non-IDS specific endpoints with some additional properties to store endpoint configuration related information. Reusage of the ids:BasicAuthentication to enable adding authentication information for ids:GenericEndpoints. GenericEndpoints are descriptive and generic (as the name suggests) and are not planned to be used for communication between IDS components (Connector / AppStore / Broker).
AppRoute should point to ids:Endpoint and not ids:AppEndpoint. Allows to refer to any kind of endpoint inside a route.
Obj.property from ids:AppRoute to ids:Resource to refer a given output of a route (e.g. a file) to a corresponding ids:Resource.