International-Data-Spaces-Association / InformationModel

The Information Model of the International Data Spaces implements the IDS reference architecture as an extensible, machine readable and technology independent data model.
Apache License 2.0
64 stars 37 forks source link

Refactor ids model enhancement (directly reuse external concepts instead of copying) #504

Closed JohannesLipp closed 2 years ago

JohannesLipp commented 3 years ago

Please see https://docs.google.com/spreadsheets/d/17RjLl6wkL_V2_jbf_vBfJ_77NgmENnf_tIfWZsNhr_Y/edit#gid=0 for details.

HaydarAk commented 2 years ago

Looks good for me, at least from an RDF perspective :)

Please resolve the two questions / fixes.

HaydarAk commented 2 years ago

Important note (and the reason why I revoked my approval) We have re-evaluate the policy-related classes and especially the codes.

The ids:Action, ids:BinaryOperator and maybe other odrl-based classes have some instances which are equivalent to the odrl counterpart while others are more precise or new. Until now this was not a concern due to the fact taht we use the idsc namespace and subClassOf relation. The reevaluation may result in two sets of actions (for example). some ids:Actions and some odrl:Action.

( Feel free to resolve existing merge conflicts, which came up until now :) )

JohannesLipp commented 2 years ago

@HaydarAk @pnlinden Please review the current state as I incorporated Haydar's request for changes w.r.t. the policies and codes. Thank you!