search

International-Data-Spaces-Association / InformationModel

The Information Model of the International Data Spaces implements the IDS reference architecture as an extensible, machine readable and technology independent data model.
Apache License 2.0
64 stars 37 forks source link

Add a callBack URL property based on the requirement of issue 495. #538

Closed changqin26 closed 2 years ago

changqin26 commented 2 years ago

Closes #495

JohannesLipp commented 2 years ago

@alexandrudanciu could you please comment if the proposed changes solve your request in #495 ? Thank you very much in advance!

DErCouch commented 2 years ago

Shouldn't it be "ResponseMessage" instead of "RequestMessage" cause by sending a request the initiating connector gives its callback URL to be addressable in the further asynchronous process.

Maybe the callback property can also be placed in the upper "Message" class to be also available in any kind of "NotificationMessages" or in some of the "ResponseMessages" (thinking about asynchronous contract negotiation proccesses).

changqin26 commented 2 years ago

Hi @DErCouch ,

in some of the "ResponseMessages" (thinking about asynchronous contract negotiation processes).

The following classes are subclasses of "ResponseMessages", can you please check if they all can have a Callback?

ResultMessage, RejectionMessage, DescriptionResponseMessage, ContractResponseMessage, ContractAgreementMessage, AccessTokenResponseMessage, ArtifactResponseMessage, UploadResponseMessage, ParticipantResponseMessage, AppRegistrationResponseMessage, AppUploadResponseMessage

Thanks!

DErCouch commented 2 years ago

@changqin26 From my perspective it is fine if the callback url is part of all request messages and notification messages, response messages don't need to be focused. I just mentioned the contract negotiation as an example here, cause some of the "responses" could be realised by notification messages if the communication is asynchronous. Request ---> MessageProcessedNotification instead of answering directly with Response.

changqin26 commented 2 years ago

@DErCouch, thanks for your clarification. Then we will have the two new updates in the latest commit. Please review.

DErCouch commented 2 years ago

@changqin26 Add me to the review list, pls

JohannesLipp commented 2 years ago

@changqin26 Add me to the review list, pls

Unfortunately, this option is not available as you are not a member of this repository apparently. Is it still possible for you to comment on the changes? As in, click "changes" and then add comments to the code lines? The result will be the same:

image

DErCouch commented 2 years ago

@changqin26 Add me to the review list, pls

Unfortunately, this option is not available as you are not a member of this repository apparently. Is it still possible for you to comment on the changes? As in, click "changes" and then add comments to the code lines? The result will be the same:

image

@JohannesLipp Nope! Not available for me, cause of missing repo rights :-(

JohannesLipp commented 2 years ago

@JohannesLipp Nope! Not available for me, cause of missing repo rights :-(

Thank you for the feedback. If possible, you could also add comments here to the PR and reference to code lines like "File X.ttl line 42". I requested the required access level for you in parallel, please stay tuned. Thank you!

JohannesLipp commented 2 years ago

@JohannesLipp Nope! Not available for me, cause of missing repo rights :-(

Thank you for the feedback. If possible, you could also add comments here to the PR and reference to code lines like "File X.ttl line 42". I requested the required access level for you in parallel, please stay tuned. Thank you!

@DErCouch you should have the required access level now, please verify, thanks! For further collaboration and access rights, please simply contact @ssteinbuss (Sebastian Steinbuss Sebastian.Steinbuss@internationaldataspaces.org) via email. Thank you very much!

ssteinbuss commented 2 years ago

@JohannesLipp Nope! Not available for me, cause of missing repo rights :-(

Thank you for the feedback. If possible, you could also add comments here to the PR and reference to code lines like "File X.ttl line 42". I requested the required access level for you in parallel, please stay tuned. Thank you!

@DErCouch you should have the required access level now, please verify, thanks! For further collaboration and access rights, please simply contact @ssteinbuss (Sebastian Steinbuss Sebastian.Steinbuss@internationaldataspaces.org) via email. Thank you very much!

Hi @DErCouch , glad to have you here in our projects and repositories. Feel welcome. We appreciate your contribution. For any organizational aspects, you can always contact @anilturkmayali (Anil.Turkmayali@internationaldataspaces.org ) or me.

Best Sebastian

JohannesLipp commented 2 years ago

@changqin26 what is the status of this?

changqin26 commented 2 years ago

@JohannesLipp I fixed the content according to the request from @alexandrudanciu , I think now we are good to merge it.