Additional t60 fixes - Githubissues

JohannesLipp commented 2 years ago

Pascal checked the situation regarding the current develop branch of the InformationModel and have found the following small issues:

codes/Action.ttl has some instances of ids:Action which does not exist anymore. Should be odrl:Action.
codes/LeftOperand.ttl has some instances of ids:LeftOperand which does not exist anymore. Should be odrl:LeftOperand.
testing/content/ResourceShape.ttl line 70 we now need dct:publisher instead of ids:publisher
testing/contract/ConstraintShape.ttl lines 26-42: AbstractConstraint should be removed? Or not have targetClass odrl:Constraint?
(minor note: utils/refactor_helper.ttl dct:MediaType comment is missing a noun in the second sentence.)
testing/participant/ParticipantShape.ttl (PersonShape) contains foaf:mbox and foaf:homepage as properties but the properties do not have foaf:Person as domain and Person is no subclass of foaf:Participant. Is this supposed to be this way? The "old" ids:Person had an emailAddress and a homepage. Currently, this is not the case due to the described situation.

changqin26 commented 2 years ago

There are still some ids:rightOperand remaining in the examples. They should also be replaced by odrl:rightOperand, right?

JohannesLipp commented 2 years ago

There are still some ids:rightOperand remaining in the examples. They should also be replaced by odrl:rightOperand, right?

Thanks for the hint! I fixed this, please check again. Thank you!

changqin26 commented 2 years ago

Looks good! I think we are good to merge it.

JohannesLipp commented 2 years ago

Looks good! I think we are good to merge it.

Perfect! Please approve this MR so I can merge it. Thank you..

International-Data-Spaces-Association / InformationModel