search

International-Data-Spaces-Association / InformationModel

The Information Model of the International Data Spaces implements the IDS reference architecture as an extensible, machine readable and technology independent data model.
Apache License 2.0
64 stars 37 forks source link

Replace sh:nodeKind sh:IRI with sh:datatype xsd:anyURI when allowed. #544

Closed changqin26 closed 2 years ago

changqin26 commented 2 years ago

Allsh:nodeKind sh:IRI appear in SHACL Shapes. I checked each one and updated to sh:datatype xsd:anyURI when possible. There are still many cases where the range in the ontology and shapes are not consistent, e.g., ids:affectedConnector has range ids:Connector in ontology but has sh:nodeKind sh:IRIin the shape. We must clarify which is correct before change them.

changqin26 commented 2 years ago

| properties | in Ontology | in Shapes | | Message ids:correlationMessage | rdfs:range ids:Message | sh:nodeKind sh:IRI | Message ids:issuerConnector | rdfs:range ids:Connector | sh:nodeKind sh:IRI | Message ids:recipientConnector | rdfs:range ids:Connector | sh:nodeKind sh:IRI | Message ids:senderAgent | rdfs:range foaf:Agent | sh:nodeKind sh:IRI | Message ids:recipientAgent | rdfs:range foaf:Agent | sh:nodeKind sh:IRI | Message ids:transferContract | rdfs:range ids:Contract | sh:nodeKind sh:IRI | Message ids:operationReference | Doesn't exist in ontology anymore

|HostShape should be removed because ids:Host is already removed.

|ids:ParameterAssignmentShape no ids:ParameterAssignment in the ontology

|Proxy ids:endpointDocumentation | here it doesn't indicate Proxy is the subclass of Endpoint, so it cannot have property ids:endpointDocumentation

|Token ids:referringConnector | ids:Connector | sh:nodeKind sh:IRI

changqin26 commented 2 years ago

The inconsistencies here listed are allowed because the URL restricted in the shapes will lead to the object describing the range in the ontology. Other points mentioned there are corrected in separate commits.

changqin26 commented 2 years ago

Hi @JohannesLipp , many thanks for pointing out the errors. I was somehow confused and made a mistake on this point. There is no need to "Replace sh:nodeKind sh:IRI with sh:datatype xsd:anyURI". I reverted all these kinds of commits. Please review again and sorry for the mistake!