search

International-Data-Spaces-Association / ids-metadata-broker-open-frontend

Apache License 2.0
0 stars 5 forks source link

Provide package-lock.json #8

Closed SebastianOpriel closed 2 years ago

SebastianOpriel commented 2 years ago

I encounter an error while installing npm packages. Please provide your package-lock.json, as it is a best practice to be committed to GIT (see e.g. https://stackoverflow.com/a/44210813)

SebastianOpriel commented 2 years ago

After some debugging: I disagree with @waleedshabbir1 regarding the PR https://github.com/International-Data-Spaces-Association/ids-metadata-broker-open-frontend/pull/7. It did not solve the problem addressed here: https://github.com/International-Data-Spaces-Association/ids-metadata-broker-open-frontend/issues/2. Additionally I needed to use the command npm install --legacy-peer-deps

waleedshabbir1 commented 2 years ago

Package-lock.json is now locked in https://github.com/International-Data-Spaces-Association/ids-metadata-broker-open-frontend/commit/be6beb6a939f7381feac7742a0bbae49909f39b3

NehaThawani44 commented 2 years ago

This duplicate issue, package-lock is committed.