search

International-Data-Spaces-Association / ids-specification

The Dataspace Protocol is a set of specifications designed to facilitate interoperable data sharing between entities governed by usage control and based on Web technologies. These specifications define the schemas and protocols required for entities to publish data, negotiate Agreements, and access data in a data space
https://docs.internationaldataspaces.org/dataspace-protocol/
Apache License 2.0
26 stars 14 forks source link

The Offer must NOT include an explicit target attribute #192

Closed matgnt closed 5 months ago

matgnt commented 6 months ago 
The Offer must NOT include an explicit target attribute

https://github.com/International-Data-Spaces-Association/ids-specification/blob/eadbaa04bbed499eb76207e92e140535a5c367bc/model/model.md?plain=1#L70

but examples do contain the target, e.g. here: https://github.com/International-Data-Spaces-Association/ids-specification/blob/ca29dbf6e720bf2a1304d6d4fd3dc963a49fcb10/negotiation/message/contract-request-message.json#L7

and also diagrams do contain the target as for example here: https://github.com/International-Data-Spaces-Association/ids-specification/blob/main/negotiation/contract.negotiation.protocol.md#1-contractrequestmessage

-- Matthias Binzer

matgnt commented 6 months ago

can someone tag this with v1 pre release, please?

juliapampus commented 6 months ago

Maybe we should distinguish the offers in the catalog from the offers within negotiation messages. The latter do have a target attribute.

matgnt commented 6 months ago

Yes, I agree. That was exactly also my conclusion :-)

jimmarino commented 6 months ago

See #193. Andrea and I just discussed this and think the best solution is to use the target attribute.

matgnt commented 5 months ago

I think we should not add this redundancy. There is also examples in Dcat explaining the situation as we have it right now, meaning the target is given by the enclosing context: https://www.w3.org/TR/vocab-dcat-3/#ex-odrl-policy

The above example does not explicitly define the ODRL Asset, so assumes the enclosing identified entity is the subject of the policy
matgnt commented 5 months ago

Update from the meeting today:

Catalog -> Dataset -> hasPolicy (Offer) MUST NOT or SHOULD NOT (still discussing...) contain the target but rather use the enclosing datasetId.

The contractRequestMessage -> dspace:Offer (Offer) MUST contain the target (as there is no enclosing context). The datasetId from the contractRquestMessage will be removed.

@sebbader @jimmarino

matgnt commented 5 months ago

Update from the meeting today:

Catalog -> Dataset -> hasPolicy (Offer) MUST NOT or SHOULD NOT (still discussing...) contain the target but rather use the enclosing datasetId.

We agreed for "MUST NOT"