search

International-Data-Spaces-Association / ids-specification

The Dataspace Protocol is a set of specifications designed to facilitate interoperable data sharing between entities governed by usage control and based on Web technologies. These specifications define the schemas and protocols required for entities to publish data, negotiate Agreements, and access data in a data space
https://docs.internationaldataspaces.org/dataspace-protocol/
Apache License 2.0
26 stars 14 forks source link

Inconsistency in ContractRequestMessage #198

Closed juliapampus closed 4 months ago

juliapampus commented 5 months ago

In the procotol, we define that a ContractRequestMessage contains either a dspace:offer or dspace:offerId. This is not reflected in the schema.

matgnt commented 5 months ago

@juliapampus where exactly? I can't find the text that allows dspace:offerId

juliapampus commented 5 months ago

@matgnt Oh sry, wrong link.. here is the section: https://github.com/International-Data-Spaces-Association/ids-specification/blob/main/negotiation/contract.negotiation.binding.https.md#261-post

juliapampus commented 5 months ago

The consumer must include the providerPid and consumerPid. The consumer must include either the offer or offerId property.

juliapampus commented 5 months ago

could be a leftover?

IgorBalog-Eng commented 5 months ago

While we review this file, there are broken json examples, that are missing comma at the end

{ "@context": "https://w3id.org/dspace/v0.8/context.json", "@type": "dspace:ContractRequest" <----- here missing comma "dspace:consumerPid": "urn:uuid:32541fe6-c580-409e-85a8-8a9a32fbe833",

and also in next json example and 3.2.1 POST "@context": "https://w3id.org/dspace/v0.8/context.json", "@type": "dspace:ContractOfferMessage" <--- here "dspace:providerPid": "urn:uuid:dcbf434c-eacf-4582-9a02-f8dd50120fd3",

and its response example

ssteinbuss commented 5 months ago

should be fixed with #184

juliapampus commented 5 months ago

will check again before closing the issue

juliapampus commented 4 months ago

I can't find any more inconsistencies.