search

International-Data-Spaces-Association / metadata-broker-open-core

This is the repository of the open-core reference implementation of the IDS Metadata Broker.
Apache License 2.0
10 stars 17 forks source link

Separate this artifacts versioning from dependencies versioning #112

Open sebplorenz opened 2 years ago

sebplorenz commented 2 years ago

With the current configuration in this project poms, it is necessary that these dependencies:

de.fraunhofer.iais.eis.ids:core:jar de.fraunhofer.iais.eis.ids:connector-commons:jar de.fraunhofer.iais.eis.ids:interaction:jar de.fraunhofer.iais.eis.ids:protocol:jar de.fraunhofer.iais.eis.ids:ecosystemintegration:jar

Have the same version number as the current artifacts to be build. This prevents building a new version of this repository without creating a new version of the dependencies (-_-)

sebplorenz commented 2 years ago

I just saw that there already is a separate version, which is set to the revision by default:

<revision>5.0.0-SNAPSHOT</revision>
<ids-components.version>${revision}</ids-components.version>
<ids-java.version>5.0.0-SNAPSHOT</ids-java.version>
<ids-serializer.version>5.0.0-SNAPSHOT</ids-serializer.version>

But:

  1. someone already separated ids-java and ids-serializer from the ids-components version. Why?
  2. the serializer version is also used for the validator. Why? 
    <dependency>
        <groupId>de.fraunhofer.iais.eis.ids</groupId>
        <artifactId>infomodel-serializer</artifactId>
        <version>${ids-serializer.version}</version>
    </dependency>
    <dependency>
        <groupId>de.fraunhofer.iais.eis.ids.infomodel</groupId>
        <artifactId>validation-serialization-provider</artifactId>
        <version>${ids-serializer.version}</version>
    </dependency>

    I think it would make sense to have a bom for the ids-components dependencies.