search

International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

ISRaD.extra.fill_soilorders not working properly #108

Closed jb388 closed 5 years ago

jb388 commented 5 years ago

ISRaD.extra.fill_soilorders function seems to just add the values from pro_soil_taxon, rather than revaluing and categorizing those values. I assume this is because the list is not exhaustive (new templates have been added/the initial list was just for profiles w/ fraction data).

greymonroe commented 5 years ago

can you elaborate on what the function is supposed to do?

coreylawrence commented 5 years ago

The purpose of this function, written by Christina at the PC meeting, was to convert soil information entered into the original templates (which was not standardized to a single convention) to USDA soil orders (I think...).

greymonroe commented 5 years ago

@jb388 I see that you closed issue #123. Does that also mean we can close this issue?

jb388 commented 5 years ago

Yes, this can be closed.