International-Soil-Radiocarbon-Database / ISRaD

Repository for the development and release of ISRaD data and tools
https://international-soil-radiocarbon-database.github.io/ISRaD/
24 stars 15 forks source link

ISRaD.build does not find path #121

Closed mguderle closed 5 years ago

mguderle commented 5 years ago

@greymonroe Grey, I do have a problem with the path settings of the ISRaD.build function. My Rproject is within the folder D:/ISRaD/ and the folder with the geo-data is a separate folder in D (D:/ISRaD_Geo). While running the function with ISRaD.build(ISRaD_directory="D:/ISRaD/", geodata_directory="D:/ISRaD_Geo") works and all computes until the update of the credits.md:

Updating credits.md page...this takes about 5 min Updating documentation and running check()... Error: Can't find 'D:\ISRaD\'.

However, credits.md is updated as far as I can see.

Do you have any idea what the problem is? Do I have to change anything in the path settings. Working directory is D:/ISRaD/. Only this works. If D:/ is the working directory the path is not found from the beginning on. I'm using RStudio in Windows 10.

mguderle commented 5 years ago

I think the issue is the definition of the ISRaD_directory. In the help it is written:

ISRaD_directory | directory where the ISRaD package is found

However, what is required is the path to the ISRaD-folder with the ISRaD_data_files folder and the data folder, which is different to the library/package path. But when ISRaD.build reaches line 137 devtools::document(pkg = ISRaD_directory) then the directory to the package itself is required (according to the devtools::document help - pkg | package description, can be path or package name).

Is that right or do I mix up something?

mguderle commented 5 years ago

Found the error, which was an additional "/".